Add ability to output multiple different masks in a single NxN tensor #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAM generates masks for each detection, however the current comfyUI mask combines all these into a single mask. This adds all the masks (assuming there is no overlap) into a single image where each mask has a different grayscale "color" similar to what is done in the grounding sam demos. The user can then post process from there.
A new field is added "mask" which defaults to "single" which is the current implementation. To output multiple the user can change single to "multiple". In the future, if there are other mask types those can be added. Also added a MultiMaskToImage node and added an image of things working.