Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic: Add non-member functions for fetch_min and fetch_max #443

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

stotko
Copy link
Owner

@stotko stotko commented Nov 18, 2024

The upcoming C++26 standard will introduce fetch_min and fetch_max functions in the atomic module. We already expose them for atomic and atomic_ref but lack the respective non-member functions. Add an implementation of these and update he signature of the remaining ones to more closely match the C++ standard.

@stotko stotko added this to the 2.0.0 milestone Nov 18, 2024
@stotko stotko force-pushed the atomic_fetch_min_max branch from 658eb6c to 2676d85 Compare November 18, 2024 14:35
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (d621e2b) to head (2676d85).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files          32       32           
  Lines        2594     2602    +8     
=======================================
+ Hits         2528     2536    +8     
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit 9005240 into master Nov 18, 2024
61 checks passed
@stotko stotko deleted the atomic_fetch_min_max branch November 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant