Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add spec.ordinals.start. #448

Merged
merged 44 commits into from
Dec 14, 2024
Merged

Conversation

vimystic
Copy link
Contributor

@vimystic vimystic commented Nov 11, 2024

  • Added spec.ordinal.start field to FullNodeSpec
  • Ran make generate & make manifests to automodify required files.
  • Updated BuildPods to accept startingOrdinal.
  • Made supporting changes for peer , configmap & service.

Completes #445

Example usage within our patchfiles for sentries & fullnodes.

Screenshot 2024-12-04 at 12 11 00 PM

Now tested in project colo-primary-test and cluster vcluster-fullnode-testnet.
This is a test with starting ordinal 9.
Please ignroe the Pending pod & pvc.
That is because there are only 2 functional workers in the test cluster.

Screenshot 2024-11-20 at 4 17 46 AM
Screenshot 2024-11-20 at 4 17 58 AM

Also tested instanceOverrides with a PVC example and a disabling pod.
Screenshot 2024-11-27 at 2 14 48 AM

@vimystic vimystic marked this pull request as ready for review November 18, 2024 11:24
@vimystic vimystic requested review from nourspace and agouin November 18, 2024 12:06
@vimystic vimystic changed the title feat: Add staringOrdinal feat: Add spec.ordinal.start. Nov 19, 2024
@vimystic vimystic marked this pull request as draft November 20, 2024 05:26
@vimystic vimystic marked this pull request as ready for review November 20, 2024 06:02
@vimystic vimystic marked this pull request as draft November 20, 2024 06:38
api/v1/cosmosfullnode_types.go Show resolved Hide resolved
api/v1/cosmosfullnode_types.go Outdated Show resolved Hide resolved
@nourspace nourspace requested a review from pharr117 December 2, 2024 16:34
Copy link
Member

@nourspace nourspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update descriptions to match that of Statefulset

@pharr117
Copy link
Contributor

pharr117 commented Dec 4, 2024

@vimystic and I did a code review walkthrough and this is looking good to me, some comments:

  1. We fixed the ordinal vs ordinals issue by modifying the struct tags
  2. We discussed the possibility of integer overflow for the int32 ordinal value and found it not too in need of attention unless someone else concerns as well
  3. Update the for loops for code consistency across all usages of the ordinal loop

I will approve once Nour's comments are fully addressed as well

@vimystic
Copy link
Contributor Author

vimystic commented Dec 4, 2024

working on making loop calls consistent now.
That will be last commit to this PR.

@vimystic
Copy link
Contributor Author

vimystic commented Dec 4, 2024

Working on fixing lint/test errors.

@vimystic vimystic requested a review from nourspace December 7, 2024 21:28
@vimystic vimystic changed the title feat: Add spec.ordinal.start. feat: Add spec.ordinals.start. Dec 9, 2024
Copy link
Member

@nourspace nourspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add happy path test for pod creation

@vimystic
Copy link
Contributor Author

Screenshot 2024-12-12 at 7 21 39 PM
I cannot merge until the above is removed.

Copy link
Member

@nourspace nourspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@vimystic vimystic merged commit 92a902e into main Dec 14, 2024
6 checks passed
@vimystic vimystic deleted the vimystic/feat/445-add-starting-ordinals branch December 14, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants