-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add spec.ordinals.start. #448
Conversation
…ead of *imaginary* name
…naming will start from spec.ordinal.start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update descriptions to match that of Statefulset
@vimystic and I did a code review walkthrough and this is looking good to me, some comments:
I will approve once Nour's comments are fully addressed as well |
working on making loop calls consistent now. |
Working on fixing lint/test errors. |
…ar to the Stateful Set description of Ordinals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add happy path test for pod creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Completes #445
Example usage within our patchfiles for sentries & fullnodes.
Now tested in project colo-primary-test and cluster vcluster-fullnode-testnet.
This is a test with starting ordinal 9.
Please ignroe the Pending pod & pvc.
That is because there are only 2 functional workers in the test cluster.
Also tested instanceOverrides with a PVC example and a disabling pod.