Skip to content

Commit

Permalink
Update docker.md (#1867)
Browse files Browse the repository at this point in the history
Proposition: when you are building for production you need to be sure that the NODE_ENV is going to be production. Thus the removal of these two lines is required (For Security).
  • Loading branch information
mpassad authored Oct 4, 2023
1 parent 6c7d20c commit 35c3ab8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions docusaurus/docs/dev-docs/installation/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,6 @@ The following `Dockerfile` can be used to build a production Docker image for a
FROM node:18-alpine as build
RUN apk update && apk add --no-cache build-base gcc autoconf automake zlib-dev libpng-dev vips-dev git > /dev/null 2>&1
ENV NODE_ENV=production
ENV NODE_ENV=${NODE_ENV}
WORKDIR /opt/
COPY package.json yarn.lock ./
Expand All @@ -353,7 +352,6 @@ RUN yarn build
FROM node:18-alpine
RUN apk add --no-cache vips-dev
ENV NODE_ENV=production
ENV NODE_ENV=${NODE_ENV}
WORKDIR /opt/
COPY --from=build /opt/node_modules ./node_modules
WORKDIR /opt/app
Expand Down

1 comment on commit 35c3ab8

@vercel
Copy link

@vercel vercel bot commented on 35c3ab8 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

documentation – ./

documentation-git-main-strapijs.vercel.app
documentation-strapijs.vercel.app
docs-vercel-v4.strapi.io

Please sign in to comment.