Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for correctness of feature argument number when parsing feature arguments #556

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Check for correctness of feature argument number when parsing feature arguments #556

wants to merge 14 commits into from

Commits on Aug 27, 2020

  1. Check for correctness of user-inputted feature argument number

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    ccbff06 View commit details
    Browse the repository at this point in the history

  2. Add tests for correct and incorrect feature argument number inputs

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    f869f13 View commit details
    Browse the repository at this point in the history

  3. Improve error message, fix test assertion

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    7db8c90 View commit details
    Browse the repository at this point in the history

  4. Simplify code

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    d58bfec View commit details
    Browse the repository at this point in the history

  5. Remove repeated computation

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    ef6538a View commit details
    Browse the repository at this point in the history

  6. Apply fix to ThinPoolDev

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    20c3e14 View commit details
    Browse the repository at this point in the history

  7. Apply fix to CacheDev

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    f5aa005 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary return of an error, add another test, make error m… 

    …essage broader
    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    6988a4b View commit details
    Browse the repository at this point in the history

  9. Improve error message, add another error message

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    950b338 View commit details
    Browse the repository at this point in the history

  10. Calculate end_feature_args_index before feature_args, use end_feature… 

    …_args_index in feature_args calculation, place check for inputs with too few values after end_feature_args_calculation, add test for inputs with too few values
    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    253aa6e View commit details
    Browse the repository at this point in the history

  11. Replace previous "...too_few" test with Mulhern's test

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    2614a75 View commit details
    Browse the repository at this point in the history

  12. Remove newline

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    d23de3e View commit details
    Browse the repository at this point in the history

  13. Drop block, make error message consistent

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    455a173 View commit details
    Browse the repository at this point in the history

  14. Add another test, express condition in an equivalent, but different way

    @waltdisgrace
    waltdisgrace committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    f93dc0d View commit details
    Browse the repository at this point in the history