Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3129, simply provide a default #3331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Jan 10, 2024

Description

Quite simple solution for a nasty bug:

because a default or default_factory is missing, dataclasses requires for relay.node annotations on subtypes (see bugreport) a value.

The reason why I didn't use default_factory (instead of the staticmethod stuff) in the tests is, that there is a bug preventing this (not scope of the PR)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented Jan 10, 2024

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to Alexander for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #3331 (56718fb) into main (ba65949) will decrease coverage by 0.31%.
The diff coverage is 96.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3331      +/-   ##
==========================================
- Coverage   96.62%   96.32%   -0.31%     
==========================================
  Files         485      485              
  Lines       30292    30313      +21     
  Branches     3746     3745       -1     
==========================================
- Hits        29271    29200      -71     
- Misses        832      901      +69     
- Partials      189      212      +23     

Copy link

codspeed-hq bot commented Jan 10, 2024

CodSpeed Performance Report

Merging #3331 will not alter performance

Comparing devkral:fix/node_without_default (56718fb) with main (ba65949)

Summary

✅ 12 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants