Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection shutdown, channel close data race #196

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

connection shutdown, channel close data race #196

wants to merge 3 commits into from
+210 −88

Commits on Nov 29, 2016

  1. safer and fail-faster reading of bogus frames

    @imkira
    imkira committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    9831e04 View commit details
    Browse the repository at this point in the history

  2. fix data race in connection shutdown and channel close

    @imkira
    imkira committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    f09251f View commit details
    Browse the repository at this point in the history

  3. enforce wait for all goroutines in client tests 

    client test code was opening connections in separate goroutines but not
waiting their termination. This is particularly dangerous if any calls
are made (asynchronously) to testing.*.Log* after the test function is
over. Not only the behavior is undefined, it was causing a data race in
go1.6 which is fixed in go1.7 by the following commit:

golang/go@5c83e65
    @imkira
    imkira committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    524f95a View commit details
    Browse the repository at this point in the history