Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made with @EwenQuim
Summary
We added colorizing to the terminal output of tests, while avoiding to print escaping characters when the output is outside a classic terminal.
Changes
more changes to come, for now only the
Equal
function has been colorizedcolors.go
file handling colorization in the assert packageMotivation
Users have been requesting to color the output of tests (#946)
Lots of PR to colorize the result do not take into account whether the output is in a terminal or not
Example usage
Performance
Inside a terminal - small performance loss
Outside a terminal - no performance loss
Next steps
We only colorized the Equal function, but if this pleases the maintainers we can also colorized all calls to
Fail
, and are open to suggestionsRelated issues
Closes #946