Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show blocked brands in CBC dropdown, but block selection #4489

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Jan 22, 2025

Summary

  • Instead of just hiding disallowed card brands in the CBC dropdown, we should instead show them as disabled and prevent them from being selected. When the user attempts to scroll to a disallowed brand it is "rolled back" to the previous selection.

Update card flow

Simulator.Screen.Recording.-.iOS.18.-.2025-01-22.at.09.45.28.mp4

New card flow

Simulator.Screen.Recording.-.iOS.18.-.2025-01-23.at.09.25.00.mp4

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3035

Testing

  • New unit test
  • Manual

Changelog

N/A (private beta for now)

@stripe stripe deleted a comment from github-actions bot Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

(not accepted)

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

@porter-stripe
Copy link
Collaborator Author

porter-stripe commented Jan 23, 2025

Added the "ship without translations" b/c:

  1. This feature is in private beta
  2. None of the merchants using this feature use CBC

By the time we GA this feature translations will have come in, we won't GA until they do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant