Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dynamic textfields for nonProxyHosts #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JohanDelValleV
Copy link

@JohanDelValleV JohanDelValleV commented Dec 7, 2020

Pull Request Description

This pull request closes strongbox/strongbox#1703

Acceptance Test

  • Building the code with ng build still works.
  • Building the code with ng test still works.
  • Building the code with ng e2e still works.

Questions

  • Does this pull request break backward compatibility?

    • Yes
    • No
  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No
  • Does this require an update of the documentation?

    • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
    • No

Code Review And Pre-Merge Checklist

  • My code follows the coding convention of this project.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@JohanDelValleV JohanDelValleV marked this pull request as ready for review December 8, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants