Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better control the number of GRanges #1803

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

lldelisle
Copy link

This PR does mainly 2 things:

  • Adds an option to force FeatureMatrix to return as many rows as input granges (very useful when you have peaks on some chromosomes which are not covered in all samples).
  • Fixes CreateMotifMatrix so it always get the good number of rows. This also implies:
    • Modification of an example
    • Enable cell to be null in AddMissing to only modify features.

I added tests but tests are limited as motifmatchr is not a dependency.

@timoast timoast changed the base branch from master to develop October 21, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant