Prevent table creation and addition with result sizes that are too la…

…rge (foundryvtt#15039)
stwlam · Jun 10, 2024 · aa02bdb · aa02bdb
1 parent 7907630
commit aa02bdb
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/module/apps/compendium-browser/tabs/base.ts b/src/module/apps/compendium-browser/tabs/base.ts
@@ -43,6 +43,9 @@ export abstract class CompendiumBrowserTab {
      *  By default none, so resuts would only contain the id field. */
     storeFields: string[] = [];
 
+    /** Maximum size to create a roll table from as a sanity check, erring towards still too large. */
+    #MAX_TABLE_SIZE = 1000;
+
     constructor(browser: CompendiumBrowser) {
         this.browser = browser;
     }
@@ -321,6 +324,17 @@ export abstract class CompendiumBrowserTab {
         if (!this.isInitialized) {
             throw ErrorPF2e(`Compendium Browser Tab "${this.tabName}" is not initialized!`);
         }
+
+        if (this.currentIndex.length > this.#MAX_TABLE_SIZE) {
+            ui.notifications.warn(
+                game.i18n.format("PF2E.CompendiumBrowser.RollTable.TooManyResults", {
+                    size: this.currentIndex.length,
+                    maxSize: this.#MAX_TABLE_SIZE,
+                }),
+            );
+            return;
+        }
+
         const content = await renderTemplate("systems/pf2e/templates/compendium-browser/roll-table-dialog.hbs", {
             count: this.currentIndex.length,
         });
@@ -348,6 +362,17 @@ export abstract class CompendiumBrowserTab {
         if (!this.isInitialized) {
             throw ErrorPF2e(`Compendium Browser Tab "${this.tabName}" is not initialized!`);
         }
+
+        if (this.currentIndex.length > this.#MAX_TABLE_SIZE) {
+            ui.notifications.warn(
+                game.i18n.format("PF2E.CompendiumBrowser.RollTable.TooManyResults", {
+                    size: this.currentIndex.length,
+                    maxSize: this.#MAX_TABLE_SIZE,
+                }),
+            );
+            return;
+        }
+
         const content = await renderTemplate("systems/pf2e/templates/compendium-browser/roll-table-dialog.hbs", {
             count: this.currentIndex.length,
             rollTables: game.tables.contents,

diff --git a/static/lang/en.json b/static/lang/en.json
@@ -971,6 +971,7 @@
                 "CreateDialogText": "Create Roll Table with {count} result(s)?",
                 "CreateLabel": "Create Roll Table",
                 "SelectTableTitle": "Select Roll Table",
+                "TooManyResults": "The result list of size {size} is too large. Maximum size is {maxSize}",
                 "WeightLabel": "Weight"
             },
             "Settings": {