[WIP] Coupled solver for thermoelasticity #2404

Vaish-W · 2024-12-26T00:59:13Z

Proposed Changes

This pull request implements integration of a heat solver coupling with the FEA solver for thermoelasticity simulations.

Key Changes:

CSolverFactory:
- Added logic to instantiate the heat solver (HEAT_SOL) conditionally when WEAKLY_COUPLED_HEAT_EQUATION is enabled in the configuration.
CFEAIteration:
- Modified the Iterate function to invoke the SingleGrid_Iteration method of the heat solver before solving the FEA equations.
CFEASolver:
- Updated Preprocessing to store a pointer to the heat solver for use in FEA computations.
- Integrated temperature handling from the heat solver in stiffness matrix and stress computations:
  - Compute_StiffMatrix
  - Compute_StiffMatrix_NodalStressRes
  - Compute_NodalStressRes
  - Compute_NodalStress
Output Enhancements:
- Extended CElasticityOutput to include temperature-related fields for coupled simulations.
- Adapted LoadVolumeData and LoadHistoryData in CElasticityOutput to retrieve and display heat solver output such as nodal temperatures and thermal residuals.

Related Work

Continuation of work from PR #2398 and #2399

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

…eGrid_Iteration in CFEAIteration

…o coupled_thermoelasticity Add nodal temperature integration in Compute_StiffMatrix

Vaish-W · 2025-01-02T20:02:39Z

While working on Compute_StiffMatrix, I noticed that NodalTemperature is not being recognized in some parts of the code. Could you clarify how NodalTemperature should be properly defined or accessed in the context of CElement or other relevant classes?

pcarruscag · 2025-01-02T20:49:30Z

SU2_CFD/src/solvers/CFEASolver.cpp

+                        auto nodal_temperatures = dynamic_cast<CSolver *>(heat_solver)->GetNodalTemperature();
+                        element->SetTemperature(iNode, nodal_temperatures[indexNode[iNode]]);


Temperature is the solution of the heat solver, the "solution" (and other fields) are stored in CVariable classes which are the "nodes" member of the solvers.

Suggested change

auto nodal_temperatures = dynamic_cast<CSolver *>(heat_solver)->GetNodalTemperature();

element->SetTemperature(iNode, nodal_temperatures[indexNode[iNode]]);

const su2double temperature = heat_solver->GetNodes()->GetSolution(indexNode[iNode], 0);

element->SetTemperature(iNode, nodal_temperature);

pcarruscag · 2025-01-02T20:50:33Z

SU2_CFD/include/solvers/CFEASolver.hpp

@@ -28,6 +28,7 @@
 #pragma once

 #include "CFEASolverBase.hpp"
+#include "CHeatSolver.hpp"


You don't need to include CHeatSolver anymore because you are only using the virtual interface (CSolver).

Suggested change

#include "CHeatSolver.hpp"

pcarruscag · 2025-01-03T16:28:23Z

Tutorials

I think you added this by mistake

pcarruscag

Looks good, does it work?

pcarruscag · 2025-01-03T16:29:04Z

SU2_CFD/src/solvers/CFEASolver.cpp

+
+            if (de_effects) {
+              de_elem->SetTemperature(iNode, temperature);
+            }


The DE elements don't use temperature

Suggested change

if (de_effects) {

de_elem->SetTemperature(iNode, temperature);

}

pcarruscag · 2025-01-03T16:30:56Z

SU2_CFD/include/output/CElasticityOutput.hpp

@@ -37,6 +37,7 @@
 class CElasticityOutput final: public COutput {
 protected:

+  const CSolver *heat_solver = nullptr; //!< Pointer to the heat solver


This doesn't need to be a member variable, the output function have access to the solver container, see CElasticityOutput::LoadHistoryData

pcarruscag · 2025-01-03T16:31:15Z

SU2_CFD/include/output/CElasticityOutput.hpp

+  /*!
+   * \brief Set the heat solver pointer for output integration.
+   * \param[in] solver - Pointer to the heat solver.
+   */
+  void SetHeatSolver(const CSolver *solver) {
+    heat_solver = solver;
+  }
+


Also not necessary

Suggested change

/*!

* \brief Set the heat solver pointer for output integration.

* \param[in] solver - Pointer to the heat solver.

*/

void SetHeatSolver(const CSolver *solver) {

heat_solver = solver;

}

pcarruscag · 2025-01-03T16:33:04Z

SU2_CFD/src/output/CElasticityOutput.cpp

+  AddHistoryOutput("RMS_TEMPERATURE", "rms[T]", ScreenOutputFormat::FIXED, "RMS_RES", "Root mean square residual of the temperature", HistoryFieldType::RESIDUAL);
+  AddHistoryOutput("MAX_TEMPERATURE", "max[T]", ScreenOutputFormat::FIXED, "MAX_RES", "Maximum residual of the temperature", HistoryFieldType::RESIDUAL);
+  AddHistoryOutput("AVG_TEMPERATURE", "avg[T]", ScreenOutputFormat::SCIENTIFIC, "HEAT", "Average temperature on all surfaces", HistoryFieldType::COEFFICIENT);
+  AddHistoryOutput("TOTAL_HEATFLUX", "HF", ScreenOutputFormat::SCIENTIFIC, "HEAT", "Total heat flux on all surfaces", HistoryFieldType::COEFFICIENT);
+  AddHistoryOutput("MAXIMUM_HEATFLUX", "MaxHF", ScreenOutputFormat::SCIENTIFIC, "HEAT", "Maximum heat flux on all surfaces", HistoryFieldType::COEFFICIENT);


You need to check if the heat solver exists here too

Also in volume output fields right?

Instantiation of solver in CSolverFactory and add a call to the Singl…

3a0b257

…eGrid_Iteration in CFEAIteration

Vaish-W added PR: draft changelog:feature labels Dec 26, 2024

Vaish-W requested a review from pcarruscag December 26, 2024 01:02

bigfooted and others added 3 commits December 28, 2024 19:06

Merge branch 'develop' into coupled_thermoelasticity

9daea2e

Add nodal temperature integration in Compute_StiffMatrix

323c27b

Merge branch 'coupled_thermoelasticity' of github.com:Vaish-W/SU2 int…

46249b6

…o coupled_thermoelasticity Add nodal temperature integration in Compute_StiffMatrix

pcarruscag reviewed Jan 2, 2025

View reviewed changes

Handle temperature from the heat_solver

60d7b6c

Vaish-W force-pushed the coupled_thermoelasticity branch from f48826a to 60d7b6c Compare January 3, 2025 11:01

Output solution for the heat solver in CElasticityOutput

b1499dd

Vaish-W requested a review from pcarruscag January 3, 2025 12:34

pcarruscag reviewed Jan 3, 2025

View reviewed changes

Tutorials Outdated

Copy link

Member

pcarruscag Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this by mistake

pcarruscag reviewed Jan 3, 2025

View reviewed changes

Vaish-W added 2 commits January 3, 2025 18:25

Remove Tutorials folder from the repository

0298a31

Add a check for the heat solver

3c83bbe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Coupled solver for thermoelasticity #2404

[WIP] Coupled solver for thermoelasticity #2404

Vaish-W commented Dec 26, 2024 •

edited

Loading

Vaish-W commented Jan 2, 2025

pcarruscag Jan 2, 2025

pcarruscag Jan 2, 2025

pcarruscag Jan 3, 2025

pcarruscag left a comment

pcarruscag Jan 3, 2025

pcarruscag Jan 3, 2025

pcarruscag Jan 3, 2025

pcarruscag Jan 3, 2025

Vaish-W Jan 3, 2025

		auto nodal_temperatures = dynamic_cast<CSolver *>(heat_solver)->GetNodalTemperature();
		element->SetTemperature(iNode, nodal_temperatures[indexNode[iNode]]);

[WIP] Coupled solver for thermoelasticity #2404

Are you sure you want to change the base?

[WIP] Coupled solver for thermoelasticity #2404

Conversation

Vaish-W commented Dec 26, 2024 • edited Loading

Proposed Changes

Related Work

PR Checklist

Vaish-W commented Jan 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcarruscag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vaish-W commented Dec 26, 2024 •

edited

Loading