Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

chore: Fork rs-ucan into noosphere-ucan and noosphere-ucan-key-support #815

Merged
merged 1 commit into from
Feb 20, 2024
Merged

chore: Fork rs-ucan into noosphere-ucan and noosphere-ucan-key-support #815

merged 1 commit into from
Feb 20, 2024

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Feb 8, 2024

Bump internal version of ed25519-zebra to 4.

@jsantell jsantell force-pushed the ucan-fork branch 3 times, most recently from 48a44e5 to 0c969b2 Compare February 8, 2024 20:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

Test flake analysis

status platform features toolchain
🟡 macos-13 test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers nightly
🟢 windows-latest test-kubo,headers stable
🟢 macos-13 test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers stable

Flake summary for macos-13, test-kubo,headers,rocksdb, stable

     Summary [  63.758s] 208 tests run: 208 passed (1 flaky), 2 skipped
   FLAKY 2/5 [   8.024s] noosphere::distributed_basic synchronize_petnames_as_they_are_added_and_removed

@jsantell jsantell force-pushed the ucan-fork branch 11 times, most recently from 0e906a1 to 8922c36 Compare February 9, 2024 20:33
@jsantell jsantell requested a review from cdata February 9, 2024 20:35
@jsantell jsantell mentioned this pull request Feb 10, 2024
Closed
@jsantell
Copy link
Contributor Author

jsantell commented Feb 13, 2024 •
edited
Loading

Rebased unsigned-varint collision with #825

edit: more nightly lints popping up, changes from original ucan are:

  • Bump MSRV to 1.75.0
  • Replace ToString implementations with Display (in other noosphere-* as well)
  • Derive Default implementation where possible rather than explicit impl Default (in other noosphere-* as well)

@jsantell jsantell force-pushed the ucan-fork branch 8 times, most recently from cf11a91 to 217d1b9 Compare February 13, 2024 23:06
cdata
cdata previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming slight touch-ups. Thanks for doing this!

rust/noosphere-storage/Cargo.toml Outdated Show resolved Hide resolved
rust/noosphere-ucan/README.md Show resolved Hide resolved
@jsantell
Copy link
Contributor Author

Patching the latest nightly lints as well https://github.com/subconsciousnetwork/noosphere/actions/runs/7978793781/job/21784685442?pr=815

@jsantell
chore: Fork rs-ucan into noosphere-ucan and noosphere-ucan-key-support.
31b2933 
* Use local crates as workspace dependencies.
* Fix a handful of lints on latest nightly.
@jsantell jsantell merged commit 0cf8f63 into main Feb 20, 2024
22 checks passed
@jsantell jsantell deleted the ucan-fork branch February 20, 2024 20:09
This was referenced Feb 20, 2024
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdata cdata cdata left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsantell @cdata