updated email validation regex #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdarshGT33 is attempting to deploy a commit to the subhadeep3902's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Welcome to Blox AI! 🎉 Thank you for submitting your pull request. We're excited to review it! 🚀 If you haven't already, be sure to check out our site to learn more about how Blox AI makes crafting flowcharts and diagrams a breeze, and how you can get explanations from the top Google Gemini model about your creations. Start visualizing your ideas today! Visit Blox AI for more information. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AdarshGT33 List ur contribution in the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Issue #138
Description
Updated the regex to validate only approved emails with approved domains
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
Future Scope:
Why didn't we used Zod for validation? I argue that we should implement Zod. I didn't moved forward with it cause that would mean some major refactoring in the code and I was not sure about it. But I would say that Zod will make it easier and also this is the future scope for this functionality as regex are not the horse for the long run.