Skip to content

Commit

Permalink
fix: replace "globalSettings" with "settings" (#68)
Browse files Browse the repository at this point in the history
* fix: replace "globalSettings" with "settings"

"globalSettings" seems to be no longer working for `ruff`.
It works for `ruff-lsp`.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>

* chore: remove/deprecate "showNotification" setting

It only works in VS Code.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>

---------

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
  • Loading branch information
jfcherng authored Jul 24, 2024
1 parent e6b7144 commit 1f984bd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
7 changes: 1 addition & 6 deletions LSP-ruff.sublime-settings
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
"initializationOptions": {
"settings": {
// same as globalSettings
},
// See https://docs.astral.sh/ruff/editors/settings/
"globalSettings": {
"settings": {
// Path to a ruff.toml or pyproject.toml file to use for configuration.
// By default, Ruff will discover configuration for each project from the filesystem, mirroring the behavior of the Ruff CLI.
"configuration": null,
Expand All @@ -28,8 +25,6 @@
"lint.preview": null,
// Sets the tracing level for the extension.
"logLevel": "error",
// Setting to control when a notification is shown.
"showNotification": "off",
// Whether to register Ruff as capable of handling source.organizeImports actions.
"organizeImports": true,
// Whether to register Ruff as capable of handling source.fixAll actions.
Expand Down
6 changes: 2 additions & 4 deletions sublime-package.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@
"showNotification": {
"type": "string",
"default": "off",
"description": "Setting to control when a notification is shown."
"description": "Setting to control when a notification is shown.",
"deprecationMessage": "This option only works in VS Code."
},
"organizeImports": {
"type": "boolean",
Expand Down Expand Up @@ -128,9 +129,6 @@
"properties": {
"settings": {
"$ref": "sublime://settings/LSP-ruff#/definitions/LspRuffSettings",
},
"globalSettings": {
"$ref": "sublime://settings/LSP-ruff#/definitions/LspRuffSettings",
}
}
}
Expand Down

0 comments on commit 1f984bd

Please sign in to comment.