Skip to content

Commit

Permalink
[sophora-webclient] javaOptions and extraEnv can now be configured
Browse files Browse the repository at this point in the history
  • Loading branch information
philmtd committed Nov 26, 2024
1 parent 12b3ab0 commit babadac
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/sophora-webclient/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.3.0
version: 1.4.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
5 changes: 5 additions & 0 deletions charts/sophora-webclient/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ spec:
image: "{{ .Values.image.name }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy | quote }}
env:
- name: JDK_JAVA_OPTIONS
value: {{ .Values.javaOptions }}
- name: SOPHORA_CLIENT_SERVERCONNECTION_USERNAME
valueFrom:
secretKeyRef:
Expand All @@ -49,6 +51,9 @@ spec:
value: {{ .Values.ingress.host | quote }}
- name: SOPHORA_CLIENT_HTTPS_PORT
value: "443"
{{- if .Values.extraEnv -}}
{{- toYaml .Values.extraEnv | nindent 10 }}
{{- end }}
ports:
- containerPort: 8080
name: http
Expand Down
6 changes: 6 additions & 0 deletions charts/sophora-webclient/test-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ webclient:
a:
b: test2

extraEnv:
- name: FOO
value: bar
- name: EXTRA_ENV
value: extra-spicy-value

extraDeploy:
- |
apiVersion: keda.sh/v1alpha1
Expand Down
4 changes: 4 additions & 0 deletions charts/sophora-webclient/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ hostAliases:

imagePullSecrets: []

javaOptions: "-XX:InitialRAMPercentage=50.0 -XX:MaxRAMPercentage=80.0 -XX:+ExitOnOutOfMemoryError -XX:+PerfDisableSharedMem"

podAnnotations: {}

sophora:
Expand Down Expand Up @@ -53,6 +55,8 @@ service:

extraDeploy: []

extraEnv:

serviceMonitor:
enabled: false
interval: 10s
Expand Down

0 comments on commit babadac

Please sign in to comment.