Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sophora-cluster-common] add Sophora cluster common chart #52

Merged
merged 5 commits into from
Oct 13, 2023
Merged

[sophora-cluster-common] add Sophora cluster common chart #52

merged 5 commits into from
Oct 13, 2023

Conversation

philmtd
Copy link
Member

@philmtd philmtd commented Oct 12, 2023

This chart contains common resources useful for cloud installations of Sophora.

tom-schoener
tom-schoener requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tom-schoener tom-schoener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a useful chart to add to our public collection. I'd add a few things:

  • short Readme
  • test file
  • extraDeploy: [] block like in other charts

charts/sophora-cluster-common/values.yaml Outdated Show resolved Hide resolved
tom-schoener
tom-schoener previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tom-schoener tom-schoener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@philmtd philmtd enabled auto-merge (squash) October 13, 2023 11:55
@philmtd philmtd merged commit fd60cea into main Oct 13, 2023
2 checks passed
@philmtd philmtd deleted the add-cluster-common-chart branch October 13, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-schoener tom-schoener tom-schoener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philmtd @tom-schoener