Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sophora-server] add alerting rules #53

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[sophora-server] add alerting rules #53

merged 3 commits into from
Oct 13, 2023

Conversation

philmtd
Copy link
Member

@philmtd philmtd commented Oct 12, 2023 •
edited
Loading

This PR adds alerting rules to the chart of the Sophora server.

tom-schoener
tom-schoener requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tom-schoener tom-schoener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, it's only missing an addition to the test file.

charts/sophora-server/values.yaml Show resolved Hide resolved
tom-schoener
tom-schoener previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tom-schoener tom-schoener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@philmtd philmtd merged commit a16221d into main Oct 13, 2023
2 checks passed
@philmtd philmtd deleted the add-alertings-to-server-chart branch October 13, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-schoener tom-schoener tom-schoener approved these changes

Assignees

@philmtd philmtd

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philmtd @tom-schoener