Ran clang tidy.

substrait-io · Jul 5, 2023 · 07fc316 · 07fc316
1 parent d2e0648
commit 07fc316
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 11 deletions.
diff --git a/src/substrait/textplan/StringManipulation.cpp b/src/substrait/textplan/StringManipulation.cpp
@@ -16,4 +16,4 @@ bool endsWith(std::string_view haystack, std::string_view needle) {
  haystack.substr(haystack.size() - needle.size(), needle.size()) == needle;
 }
 
-}  // namespace io::substrait::textplan
+} // namespace io::substrait::textplan
diff --git a/src/substrait/textplan/StringManipulation.h b/src/substrait/textplan/StringManipulation.h
@@ -12,4 +12,4 @@ bool startsWith(std::string_view haystack, std::string_view needle);
 // Returns true if the string 'haystack' ends with the string 'needle'.
 bool endsWith(std::string_view haystack, std::string_view needle);
 
-}  // namespace io::substrait::textplan
+} // namespace io::substrait::textplan
diff --git a/src/substrait/textplan/converter/PlanPrinterVisitor.cpp b/src/substrait/textplan/converter/PlanPrinterVisitor.cpp
@@ -760,10 +760,10 @@ std::any PlanPrinterVisitor::visitReadRelation(
  return "";
  }
 
- auto mainSymbol = symbolTable_->lookupSymbolByLocationAndType(PROTO_LOCATION(relation), SymbolType::kRelation);
+ auto mainSymbol = symbolTable_->lookupSymbolByLocationAndType(
+ PROTO_LOCATION(relation), SymbolType::kRelation);
 
- auto symbols = symbolTable_->lookupSymbolsByLocation(
- PROTO_LOCATION(*msg));
+ auto symbols = symbolTable_->lookupSymbolsByLocation(PROTO_LOCATION(*msg));
  if (!symbols.empty()) {
  text << " source " << symbols[0]->name << ";\n";
  }
@@ -826,7 +826,8 @@ std::any PlanPrinterVisitor::visitAggregateRelation(
  }
  for (const auto& measure : relation.measures()) {
  if (!measure.has_measure()) {
- errorListener_->addError("Encountered aggregate measure without a measure function.");
+ errorListener_->addError(
+ "Encountered aggregate measure without a measure function.");
  continue;
  }
  text << " measure {\n";

diff --git a/src/substrait/textplan/parser/SubstraitPlanVisitor.cpp b/src/substrait/textplan/parser/SubstraitPlanVisitor.cpp
@@ -254,7 +254,11 @@ std::any SubstraitPlanVisitor::visitRoot_relation(
  names.push_back(id->getText());
  }
  symbolTable_->defineSymbol(
- kRootNames, Location(ctx), SymbolType::kRoot, SourceType::kUnknown, names);
+ kRootNames,
+ Location(ctx),
+ SymbolType::kRoot,
+ SourceType::kUnknown,
+ names);
  return nullptr;
 }
 

diff --git a/src/substrait/textplan/tests/RoundtripTest.cpp b/src/substrait/textplan/tests/RoundtripTest.cpp
@@ -97,10 +97,7 @@ TEST_P(RoundTripBinaryToTextFixture, RoundTrip) {
  ASSERT_THAT(
  result,
  ::testing::AllOf(
- ParsesOk(),
- HasErrors({}),
- AsBinaryPlan(
- EqualsProto(normalizedPlan))))
+ ParsesOk(), HasErrors({}), AsBinaryPlan(EqualsProto(normalizedPlan))))
  << std::endl
  << "Intermediate result:" << std::endl
  << addLineNumbers(outputText) << std::endl