Skip to content

Commit

Permalink
fix: get CI working again (#102)
Browse files Browse the repository at this point in the history
Adds an explicit timeout and retry to ensure that we don't run too long
(and can identify any tests that are getting stalled out).
  • Loading branch information
EpsilonPrime committed Mar 15, 2024
1 parent abad742 commit 3f84014
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,15 @@ jobs:
with:
submodules: recursive
- name: Setup Ubuntu
run: ./scripts/setup-ubuntu.sh
- run: mkdir build
run: |
./scripts/setup-ubuntu.sh
mkdir build
- name: Run cmake
run: cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TZ_LIB=ON
run: |
cmake --version
cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TZ_LIB=ON
- name: Build
run: ninja -C build
- name: Test
run: ctest --test-dir build --output-on-failure
run: ctest --test-dir build --output-on-failure --timeout 30

2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)

option(SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD
"Turns on address and undefined memory sanitization runtime checking."
ON)
OFF)

if(${SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD})
add_compile_options($<$<CONFIG:Debug>:-fsanitize=undefined>)
Expand Down
7 changes: 0 additions & 7 deletions export/planloader/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
# SPDX-License-Identifier: Apache-2.0

if(CMAKE_BUILD_TYPE MATCHES Debug)
message(
WARNING
"The planloader library does not work well in Debug mode due to bundled heap checking."
)
endif()

add_library(planloader SHARED planloader.cpp)

add_dependencies(planloader substrait_io)
Expand Down

0 comments on commit 3f84014

Please sign in to comment.