More signature changes.

substrait-io · Jul 27, 2023 · 68e7e60 · 68e7e60
1 parent 4979f02
commit 68e7e60
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/substrait/textplan/converter/SaveBinary.cpp b/src/substrait/textplan/converter/SaveBinary.cpp
@@ -20,7 +20,7 @@ namespace io::substrait::textplan {
 
 absl::Status savePlanToBinary(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename) {
+ std::string_view output_filename) {
  int outputFileDescriptor =
  creat(std::string{output_filename}.c_str(), S_IREAD | S_IWRITE);
  if (outputFileDescriptor == -1) {
@@ -42,7 +42,7 @@ absl::Status savePlanToBinary(
 
 absl::Status savePlanToJson(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename) {
+ std::string_view output_filename) {
  int outputFileDescriptor =
  creat(std::string{output_filename}.c_str(), S_IREAD | S_IWRITE);
  if (outputFileDescriptor == -1) {
@@ -70,7 +70,7 @@ absl::Status savePlanToJson(
 
 absl::Status savePlanToText(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename) {
+ std::string_view output_filename) {
  std::ofstream stream(output_filename);
 
  auto result = parseBinaryPlan(plan);
@@ -85,7 +85,7 @@ absl::Status savePlanToText(
 
 absl::Status savePlanToProtoText(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename) {
+ std::string_view output_filename) {
  int outputFileDescriptor =
  creat(std::string{output_filename}.c_str(), S_IREAD | S_IWRITE);
  if (outputFileDescriptor == -1) {

diff --git a/src/substrait/textplan/converter/SaveBinary.h b/src/substrait/textplan/converter/SaveBinary.h
@@ -13,21 +13,21 @@ namespace io::substrait::textplan {
 // Serializes a plan to disk as a binary protobuf.
 absl::Status savePlanToBinary(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename);
+ std::string_view output_filename);
 
 // Serializes a plan to disk as a JSON-encoded protobuf.
 absl::Status savePlanToJson(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename);
+ std::string_view output_filename);
 
 // Calls the converter to store a plan on disk as a text-based substrait plan.
 absl::Status savePlanToText(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename);
+ std::string_view output_filename);
 
 // Serializes a plan to disk as a text-encoded protobuf.
 absl::Status savePlanToProtoText(
  const ::substrait::proto::Plan& plan,
- const std::string_view& output_filename);
+ std::string_view output_filename);
 
 } // namespace io::substrait::textplan