More fixes.

substrait-io · Jul 27, 2023 · 6cca1ca · 6cca1ca
1 parent c933bc2
commit 6cca1ca
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/substrait/textplan/converter/CMakeLists.txt b/src/substrait/textplan/converter/CMakeLists.txt
@@ -27,7 +27,8 @@ target_link_libraries(
  symbol_table
  error_listener
  date::date
- fmt::fmt-header-only)
+ fmt::fmt-header-only
+ absl::status)
 
 if(${SUBSTRAIT_CPP_BUILD_TESTING})
  add_subdirectory(tests)

diff --git a/src/substrait/textplan/parser/CMakeLists.txt b/src/substrait/textplan/parser/CMakeLists.txt
@@ -28,7 +28,8 @@ target_link_libraries(
  textplan_grammar
  fmt::fmt-header-only
  date::date
- date::date-tz)
+ date::date-tz
+ absl::status)
 
 add_executable(planparser Tool.cpp)
 

diff --git a/src/substrait/textplan/tests/RoundtripTest.cpp b/src/substrait/textplan/tests/RoundtripTest.cpp
@@ -70,12 +70,12 @@ std::vector<std::string> getTestCases() {
 
 TEST_P(RoundTripBinaryToTextFixture, RoundTrip) {
  auto filename = GetParam();
- std::string json = readFromFile(filename);
- auto planOrErrors = loadFromJson(json);
- std::vector<std::string> errors = planOrErrors.errors();
- ASSERT_THAT(errors, ::testing::ElementsAre());
+ auto jsonOrError = readFromFile(filename);
+ ASSERT_TRUE(jsonOrError.ok());
+ auto planOrError = loadFromJson(*jsonOrError);
+ ASSERT_TRUE(planOrError.ok());
 
- auto plan = *planOrErrors;
+ auto plan = *planOrError;
 
  auto textResult = parseBinaryPlan(plan);
  auto textSymbols = textResult.getSymbolTable().getSymbols();