move datetime into a package

substrait-io · Aug 18, 2023 · 714f486 · 714f486
1 parent e53dd8b
commit 714f486
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 5 deletions.
diff --git a/src/substrait/textplan/converter/CMakeLists.txt b/src/substrait/textplan/converter/CMakeLists.txt
@@ -1,5 +1,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
+include(../../../../third_party/datetime.cmake)
+
 set(TEXTPLAN_SRCS
  InitialPlanProtoVisitor.cpp
  InitialPlanProtoVisitor.h

diff --git a/src/substrait/textplan/parser/CMakeLists.txt b/src/substrait/textplan/parser/CMakeLists.txt
@@ -1,5 +1,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
+include(../../../../third_party/datetime.cmake)
+
 add_subdirectory(grammar)
 
 add_library(

diff --git a/third_party/CMakeLists.txt b/third_party/CMakeLists.txt
@@ -1,12 +1,11 @@
 # SPDX-License-Identifier: Apache-2.0
 
 if(NOT ${ABSL_INCLUDED_WITH_PROTOBUF})
- set(ABSL_PROPAGATE_CXX_STD ON)
- add_subdirectory(abseil-cpp)
+  set(ABSL_PROPAGATE_CXX_STD ON)
+  add_subdirectory(abseil-cpp)
 endif()
 
-set(BUILD_TZ_LIB ON)
-add_subdirectory(datetime)
+include(datetime.cmake)
 
 add_subdirectory(fmt)
 add_subdirectory(googletest)

diff --git a/third_party/datetime b/third_party/datetime
diff --git a/third_party/datetime.cmake b/third_party/datetime.cmake
@@ -0,0 +1,13 @@
+# SPDX-License-Identifier: Apache-2.0
+
+include_guard(GLOBAL)
+
+set (BUILD_TZ_LIB ON CACHE BOOL "timezone library is a dependency" FORCE)
+include(FetchContent)
+FetchContent_Declare(date_src
+ GIT_REPOSITORY https://github.com/HowardHinnant/date.git
+ GIT_TAG v3.0.1
+ )
+#if(NOT ${date_src_POPULATED})
+ FetchContent_MakeAvailable(date_src)
+#endif()