Skip to content

Commit

Permalink
Now calls third-party after checking protobuf dependencies to properl…
Browse files Browse the repository at this point in the history
…y determine if abseil is needed.
  • Loading branch information
EpsilonPrime committed Jul 10, 2023
1 parent 96ca9fd commit 73b48c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ option(
include_directories(include)
include_directories(src)

add_subdirectory(third_party)

# TODO: Simplify once we can require cmake 3.27 (where CONFIG is default).

# Due to packaging changes we use the combined protobuf/absl packaging if
Expand All @@ -35,6 +33,8 @@ else()
set(ABSL_INCLUDED_WITH_PROTOBUF OFF)
endif()

add_subdirectory(third_party)

list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake_modules")
include(BuildUtils)

Expand Down
4 changes: 1 addition & 3 deletions third_party/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# SPDX-License-Identifier: Apache-2.0

if(${ABSL_INCLUDED_WITH_PROTOBUF})
# Remove abseil-cpp from the repo when we can require cmake 3.27.
else()
if(NOT ${ABSL_INCLUDED_WITH_PROTOBUF})
set(ABSL_PROPAGATE_CXX_STD ON)
add_subdirectory(abseil-cpp)
endif()
Expand Down

0 comments on commit 73b48c9

Please sign in to comment.