Skip to content

Commit

Permalink
Ran clang tidy.
Browse files Browse the repository at this point in the history
  • Loading branch information
EpsilonPrime committed Feb 6, 2024
1 parent 74bf673 commit 80b2c3e
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 22 deletions.
29 changes: 29 additions & 0 deletions export/java/TextPlan.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package io.substrait;

public class SubstraitPlanLoader {
enum PlanFileFormat {
kBinary = 0,
kJson = 1,
kProtoText = 2,
kText = 3,
};

// Load a Substrait plan (in any format) from disk.
// Returns error message on failure, otherwise returns nullptr and
// updates the provided buffer.
public native String loadSubstraitPlan(String filename);

// Write a Substrait plan to disk in the specified format.
public native String saveSubstraitPlan(Plan plan, String filename, PlanFileFormat format);

static {
System.load("/path/to/libMYSTUFF.so");
}

public static void main(String [] args) {
SubstraitPlanLoader loader = new SubstraitPlanLoader();

String result = loader.loadSubstraitPlan("filename.plan");
System.out.println("Result: " + result);
}
}
10 changes: 8 additions & 2 deletions export/planloader/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# SPDX-License-Identifier: Apache-2.0

if(NOT BUILD_SUBDIR_NAME EQUAL "release")
message(SEND_ERROR, "The planloader library does not work in Debug mode due to its dependencies.")
message(
SEND_ERROR,
"The planloader library does not work in Debug mode due to its dependencies."
)
endif()

add_library(planloader SHARED planloader.cpp)
Expand All @@ -11,7 +14,10 @@ set_target_properties(planloader PROPERTIES SUBVERSION 1)
add_dependencies(planloader substrait_io)
target_link_libraries(planloader substrait_io)

install(TARGETS planloader LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} PRIVATE_HEADER DESTINATION ${CMAKE_INSTALL_INCDIR})
install(
TARGETS planloader
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
PRIVATE_HEADER DESTINATION ${CMAKE_INSTALL_INCDIR})

if(${SUBSTRAIT_CPP_BUILD_TESTING})
add_subdirectory(tests)
Expand Down
41 changes: 21 additions & 20 deletions export/planloader/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,34 +1,35 @@
# SPDX-License-Identifier: Apache-2.0

cmake_path(GET CMAKE_CURRENT_BINARY_DIR PARENT_PATH
CMAKE_CURRENT_BINARY_PARENT_DIR)
CMAKE_CURRENT_BINARY_PARENT_DIR)
cmake_path(GET CMAKE_CURRENT_BINARY_PARENT_DIR PARENT_PATH
CMAKE_CURRENT_BINARY_TOPLEVEL_DIR)
CMAKE_CURRENT_BINARY_TOPLEVEL_DIR)

set(CMAKE_RUNTIME_OUTPUT_DIRECTORY
"${CMAKE_CURRENT_BINARY_TOPLEVEL_DIR}/${BUILD_SUBDIR_NAME}")
"${CMAKE_CURRENT_BINARY_TOPLEVEL_DIR}/${BUILD_SUBDIR_NAME}")

add_test_case(
planloader_test
SOURCES
PlanLoaderTest.cpp
EXTRA_LINK_LIBS
planloader
gtest
gtest_main)
planloader_test
SOURCES
PlanLoaderTest.cpp
EXTRA_LINK_LIBS
planloader
gtest
gtest_main)

set(TEXTPLAN_SOURCE_DIR "${CMAKE_SOURCE_DIR}/src/substrait/textplan")

add_custom_command(
TARGET planloader_test
POST_BUILD
COMMAND ${CMAKE_COMMAND} -E echo "Copying unit test data.."
COMMAND ${CMAKE_COMMAND} -E make_directory
"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/tests/data"
COMMAND
${CMAKE_COMMAND} -E copy
"${TEXTPLAN_SOURCE_DIR}/converter/data/q6_first_stage.json"
"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/tests/data/q6_first_stage.json")
TARGET planloader_test
POST_BUILD
COMMAND ${CMAKE_COMMAND} -E echo "Copying unit test data.."
COMMAND ${CMAKE_COMMAND} -E make_directory
"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/tests/data"
COMMAND
${CMAKE_COMMAND} -E copy
"${TEXTPLAN_SOURCE_DIR}/converter/data/q6_first_stage.json"
"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/tests/data/q6_first_stage.json")

message(
STATUS "test data will be here: ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/tests/data")
STATUS "test data will be here: ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/tests/data"
)

0 comments on commit 80b2c3e

Please sign in to comment.