Use the .clang-tidy file

substrait-io · Jul 26, 2024 · 9561d1e · 9561d1e
1 parent 2090c60
commit 9561d1e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.clang-tidy b/.clang-tidy
@@ -77,6 +77,7 @@ Checks: >
  -bugprone-implicit-widening-of-multiplication-result,
  -bugprone-unchecked-optional-access
 WarningsAsErrors: '*'
+ExtraArgs: ['-Wno-assertions']
 HeaderFilterRegex: 'io/substrait/*.\\.h$'
 AnalyzeTemporaryDtors: false
 FormatStyle: none

diff --git a/scripts/run-clang-tidy.sh b/scripts/run-clang-tidy.sh
@@ -4,7 +4,7 @@ SCRIPTDIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 WORKDIR="$( cd $SCRIPTDIR/.. && pwd )"
 
 # Make compile_command.json
-rm -rf tmp && mkdir tmp && cmake -Btmp -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSUBSTRAIT_CPP_ROUNDTRIP_TESTING=ON -Wno-attributes
+rm -rf tmp && mkdir tmp && cmake -Btmp -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSUBSTRAIT_CPP_ROUNDTRIP_TESTING=ON
 # Build substrait protobuf
 pushd tmp/src/substrait/proto && make -j && popd || exit
 # Build textplan grammar