Remove dependency of symbol_table on textplan_converter.

substrait-io · Mar 13, 2024 · a164d92 · a164d92
1 parent 56aee3d
commit a164d92
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/substrait/proto/CMakeLists.txt b/src/substrait/proto/CMakeLists.txt
@@ -85,4 +85,5 @@ target_link_libraries(substrait_proto protobuf::libprotobuf)
 
 # Make sure we can see our own generated include files.
 target_include_directories(substrait_proto
-                           PUBLIC "${PROTO_OUTPUT_TOPLEVEL_DIR}/src")
+                           PUBLIC "${PROTO_OUTPUT_TOPLEVEL_DIR}/src"
+                           PUBLIC "${protobuf_SOURCE_DIR}/src")
diff --git a/src/substrait/textplan/CMakeLists.txt b/src/substrait/textplan/CMakeLists.txt
@@ -23,12 +23,12 @@ add_library(parse_result ParseResult.cpp ParseResult.h)
 add_dependencies(symbol_table substrait_proto substrait_common absl::strings
                  fmt::fmt-header-only)
 
-target_link_libraries(symbol_table fmt::fmt-header-only absl::strings
-                      substrait_textplan_converter)
+target_link_libraries(symbol_table substrait_proto substrait_common
+                      absl::strings fmt::fmt-header-only )
 
 # Provide access to the generated protobuffer headers hierarchy.
 target_include_directories(symbol_table
-                           PUBLIC "${CMAKE_CURRENT_BINARY_DIR}/../..")
+        PUBLIC "${CMAKE_CURRENT_BINARY_DIR}/../..")
 
 if(${SUBSTRAIT_CPP_BUILD_TESTING})
   add_subdirectory(tests)