Skip to content

Commit

Permalink
Turn off address sanitization by default. We should add a separate bu…
Browse files Browse the repository at this point in the history
…ild later to test without affecting the runtime anyway.
  • Loading branch information
EpsilonPrime committed Mar 15, 2024
1 parent 2ee89fe commit adf8429
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,5 @@ jobs:
- name: Build
run: ninja -C build
- name: Test
run: ctest --test-dir build --output-on-failure --timeout 10 --repeat until-pass:2
run: ctest --test-dir build --output-on-failure --timeout 30

2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)

option(SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD
"Turns on address and undefined memory sanitization runtime checking."
ON)
OFF)

if(${SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD})
add_compile_options($<$<CONFIG:Debug>:-fsanitize=undefined>)
Expand Down
7 changes: 0 additions & 7 deletions export/planloader/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
# SPDX-License-Identifier: Apache-2.0

if(CMAKE_BUILD_TYPE MATCHES Debug)
message(
WARNING
"The planloader library does not work well in Debug mode due to bundled heap checking."
)
endif()

add_library(planloader SHARED planloader.cpp)

add_dependencies(planloader substrait_io)
Expand Down

0 comments on commit adf8429

Please sign in to comment.