Skip to content

Commit

Permalink
Minor fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
EpsilonPrime committed Jun 21, 2023
1 parent 3b84ff5 commit d285618
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 13 deletions.
9 changes: 3 additions & 6 deletions src/substrait/textplan/converter/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,9 @@ add_executable(planconverter Tool.cpp)

target_link_libraries(planconverter substrait_textplan_converter)

set(NORMALIZER_SRCS
ReferenceNormalizer.cpp
ReferenceNormalizer.h)
set(NORMALIZER_SRCS ReferenceNormalizer.cpp ReferenceNormalizer.h)

add_library(substrait_textplan_normalizer ${NORMALIZER_SRCS})

target_link_libraries(
substrait_textplan_normalizer
substrait_textplan_converter)
target_link_libraries(substrait_textplan_normalizer
substrait_textplan_converter)
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,13 @@ std::vector<TestCase> getTestCases() {
})",
WhenSerialized(EqSquashingWhitespace(
R"(extension_space {
function lte:fp64_fp64 as lte;
function sum:fp64_fp64 as sum;
function lt:fp64_fp64 as lt;
function is_not_null:fp64 as is_not_null;
function and:bool_bool as and;
function gte:fp64_fp64 as gte;
function is_not_null:fp64 as is_not_null;
function lt:fp64_fp64 as lt;
function lte:fp64_fp64 as lte;
function multiply:opt_fp64_fp64 as multiply;
function sum:fp64_fp64 as sum;
})")),
},
{
Expand Down
4 changes: 1 addition & 3 deletions src/substrait/textplan/tests/RoundtripTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ TEST_P(RoundTripBinaryToTextFixture, RoundTrip) {
ASSERT_THAT(
result,
::testing::AllOf(
ParsesOk(),
HasErrors({}),
AsBinaryPlan(EqualsProto(normalizedPlan))))
ParsesOk(), HasErrors({}), AsBinaryPlan(EqualsProto(normalizedPlan))))
<< std::endl
<< "Intermediate result:" << std::endl
<< addLineNumbers(outputText);
Expand Down

0 comments on commit d285618

Please sign in to comment.