Handle review notes.

substrait-io · Jul 10, 2023 · d964228 · d964228
1 parent f5813a1
commit d964228
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -22,6 +22,9 @@ include_directories(src)
 
 add_subdirectory(third_party)
 
+# Due to packaging changes we use the combined protobuf/absl packaging if
+# available otherwise we fallback to the older protobuf method.
+# TODO: Simplify once we can require cmake 3.27 (where CONFIG is default).
 find_package(Protobuf QUIET CONFIG)
 if(NOT ${Protobuf_FOUND})
  find_package(Protobuf REQUIRED)

diff --git a/scripts/setup-ubuntu.sh b/scripts/setup-ubuntu.sh
@@ -21,7 +21,6 @@ sudo --preserve-env apt install -y \
  libprotobuf-dev \
  libprotobuf23 \
  protobuf-compiler \
- libabsl-dev \
  clang-format \
  uuid-dev \
  default-jre \

diff --git a/third_party/abseil-cpp b/third_party/abseil-cpp