Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get CI working again #102

Merged
merged 4 commits into from
Mar 15, 2024
Merged

fix: get CI working again #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a236f8
Add cmake version check to the workflow.
EpsilonPrime Mar 15, 2024
4172578
Add timeout and retry to make the build hopefully more resilient.
EpsilonPrime Mar 15, 2024
2ee89fe
Reduce the retries so we can see persistent issues more clearly.
EpsilonPrime Mar 15, 2024
adf8429
Turn off address sanitization by default. We should add a separate b…
EpsilonPrime Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/build_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,15 @@ jobs:
with:
submodules: recursive
- name: Setup Ubuntu
run: ./scripts/setup-ubuntu.sh
- run: mkdir build
run: |
./scripts/setup-ubuntu.sh
mkdir build
- name: Run cmake
run: cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TZ_LIB=ON
run: |
cmake --version
cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TZ_LIB=ON
- name: Build
run: ninja -C build
- name: Test
run: ctest --test-dir build --output-on-failure
run: ctest --test-dir build --output-on-failure --timeout 30

2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)

option(SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD
"Turns on address and undefined memory sanitization runtime checking."
ON)
OFF)

if(${SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD})
add_compile_options($<$<CONFIG:Debug>:-fsanitize=undefined>)
Expand Down
7 changes: 0 additions & 7 deletions export/planloader/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
# SPDX-License-Identifier: Apache-2.0

if(CMAKE_BUILD_TYPE MATCHES Debug)
message(
WARNING
"The planloader library does not work well in Debug mode due to bundled heap checking."
)
endif()

add_library(planloader SHARED planloader.cpp)

add_dependencies(planloader substrait_io)
Expand Down
Loading