Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't concatenate paths in --proto_path #109

Merged
merged 2 commits into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. Don't concatenate paths in --proto_path

    `protoc`'s `--proto_path` argument is expected to be provided multiple times if multiple directories are to be considered. Concatenating with `:` is invalid on some systems (Windows):
    
    ```sh
    > protoc --help
      -IPATH, --proto_path=PATH   Specify the directory in which to search for
                                  imports.  May be specified multiple times;
                                  directories will be searched in order.  If not
                                  given, the current working directory is used.
                                  If not found in any of the these directories,
                                  the --descriptor_set_in descriptors will be
                                  checked for required proto file.
    ```
    mortbopet committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    aa89232 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. format

    mortbopet committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    50f5e1b View commit details
    Browse the repository at this point in the history