Minimum viable changes for Windows build #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This + PRs substrait-io#109 and substrait-io#108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.
mortbopet
force-pushed
the
dev/mpetersen/win_build
branch
from
8d5da6b
to
34e3f28
Compare
|
@EpsilonPrime thank you for the review; looks like CI is back in the green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This + PRs #109 and #108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.