Don't predeclare a struct as a class #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortbopet
changed the title
|
@EpsilonPrime unsure why CI fails here; this shouldn't change anything wrt. the underlying tests. |
|
Yeah, really weird as I wouldn't expect changes to file locations to affect the correctness of one test. I will check into this when I get in. |
|
The issue is that the timezones "US/Central" and "UTC" are no longer being found in the timezone database. I am able to reproduce this issue on iOS as well. Still looking for what changed between today and yesterday. |
|
Looks like the timezone database was updated yesterday: https://lists.iana.org/hyperkitty/list/tz-announce@iana.org/thread/IZ7AO6WRE3W3TWBL5IR6PMQUL433BQIE/ |
EpsilonPrime
approved these changes
Sep 7, 2024
|
(The timezone issue appears to be fixed by #120 . Will merge this after that PR lands.) |
mortbopet
force-pushed
the
dev/mpetersen/struct_is_not_class
branch
from
59b8a2c
to
9163892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holy moly this took a long time to debug.
MSVC gives absolutely zero warnings about if a struct/class is predeclared as one or the other, during compilation.
However, linking also needs to happen. And as it turns out, whether a thing is a class or struct is part of the MSVC name mangling spec. Hence, we'd end up with e.g. this function (which references
SymbolInfo) as being defined in it's object file as the following symbol:However, things which reference
SymbolInfo, but which may have pulled in the incorrect predeclaration prior, will reference it as an incorrect symbol:e.g. notice the difference between
PEBUSymbolInfoandPEBVSymbolInfo. Enqueue strange linking issues galore.