Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw away visit result in BasePlanProtoVisitor #118

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Don't throw away visit result in BasePlanProtoVisitor #118

merged 1 commit into from
Sep 7, 2024

Commits on Sep 7, 2024

  1. Don't throw away visit result in BasePlanProtoVisitor 

    `visitPlan` is marked `protected`, meaning that non-subclasses of `BasePlanProtoVisitor` (which is probably what'll initiate the `visit` most of the time) cannot have access to the `visit` result.

Is there a specific reason that the traversal result has been hidden? If not, i suggest this change.

If so, subclasses are obviously free to implement a `visitWithResult` function to do the same thing.
    @mortbopet
    mortbopet committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    e967b33 View commit details
    Browse the repository at this point in the history