Add lint to CI include checking for cmake-format, clang-format and license header #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpsilonPrime
reviewed
Mar 3, 2023
westonpace
requested changes
Mar 4, 2023
chaojun-zhang
force-pushed
the
clint
branch
2 times, most recently
from
534e55d
to
f53261f
Compare
|
Hi @westonpace , please help to re-run and trigger the check again. |
westonpace
reviewed
Mar 20, 2023
|
I'm not sure why the build is not running. Perhaps you need to rebase to get the latest github workflows? |
https://github.com/substrait-io/substrait-cpp/actions/runs/4459109898/workflow |
chaojun-zhang
force-pushed
the
clint
branch
2 times, most recently
from
c518d9a
to
ec3a0ce
Compare
|
check failed due to file |
chaojun-zhang
force-pushed
the
clint
branch
2 times, most recently
from
04f50de
to
1e6f292
Compare
westonpace
pushed a commit
that referenced
this pull request
Mar 22, 2023
This PR should be the first PR of issue #15, and then the second [PR](#30) will use this for lint check. - please see https://github.com/apache/skywalking-eyes for license check - run-clang-tidy.py : a python script used to check cpp project with clang-tidy Co-authored-by: chaojun-zhang <zcj23085@gmail.com>
|
I've merged #37. Do you want to rebase now? If it's still failing or we need changes to those files that are checked in then let me know and I should have some time to work it out on Friday too. |
chaojun-zhang
force-pushed
the
clint
branch
10 times, most recently
from
c70082d
to
3415253
Compare
…rma and license header
|
Rebased and finally passed |
chaojun-zhang
requested review from
EpsilonPrime and
westonpace
and removed request for
westonpace and
EpsilonPrime
|
I'm looking forward to this one, it'll be nice to have something to catch when I forget the license headers! |
EpsilonPrime
pushed a commit
to EpsilonPrime/substrait-cpp
that referenced
this pull request
Mar 24, 2023
This PR should be the first PR of issue substrait-io#15, and then the second [PR](substrait-io#30) will use this for lint check. - please see https://github.com/apache/skywalking-eyes for license check - run-clang-tidy.py : a python script used to check cpp project with clang-tidy Co-authored-by: chaojun-zhang <zcj23085@gmail.com>
EpsilonPrime
pushed a commit
to EpsilonPrime/substrait-cpp
that referenced
this pull request
Mar 24, 2023
EpsilonPrime
pushed a commit
to EpsilonPrime/substrait-cpp
that referenced
this pull request
May 6, 2023
This PR should be the first PR of issue substrait-io#15, and then the second [PR](substrait-io#30) will use this for lint check. - please see https://github.com/apache/skywalking-eyes for license check - run-clang-tidy.py : a python script used to check cpp project with clang-tidy Co-authored-by: chaojun-zhang <zcj23085@gmail.com>
EpsilonPrime
pushed a commit
to EpsilonPrime/substrait-cpp
that referenced
this pull request
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lint to CI include checking for cmake-format, clang-format and license header, see #15