feat: relations and expressions binary output for the textplan parser #63
Conversation
EpsilonPrime
commented
May 31, 2023
•
EpsilonPrime
commented
| @@ -117,7 +117,15 @@ std::vector<TestCase> getTestCases() { | |||
| WhenSerialized(EqSquashingWhitespace(R"(pipelines { | |||
| myself -> a; | |||
| b -> myself; | |||
There was a problem hiding this comment.
I would think that a pipeline referring to a node that isn't defined would be an error.
| AsBinaryPlan(Partially(EqualsProto<::substrait::proto::Plan>( | ||
| R"(relations { root { input { project { | ||
| expressions { cast { type { i32 {} } input { literal { i8: 123 } } } } | ||
| expressions { cast { type { i64 {} } input { cast { type { i32 {} } input { literal { i8: 123 } } } } } } |
There was a problem hiding this comment.
I appreciate that you did not try to be clever and collapse these casts. We can save that for other tools.
| } | ||
|
|
||
| join relation join { | ||
| //type JOIN_TYPE_UNSPECIFIED; |
There was a problem hiding this comment.
Is this an example showing that we can support comments in splans?
There was a problem hiding this comment.
Was waiting for support, I've replaced this with the future syntax which is currently just getting swallowed.
EpsilonPrime
force-pushed
the
parser-part4
branch
from
5a202fc
to
d8552bb
Compare
EpsilonPrime
changed the title
* Relations are now interconnected as defined by pipelines.
* Expressions are now emitted to binary plans.
* HasErrors matcher now explains the difference in errors.
EpsilonPrime
force-pushed
the
parser-part4
branch
from
d8552bb
to
443d8ec
Compare
| // The type isn't one we expected bail. | ||
| return; |
There was a problem hiding this comment.
We might consider some kind of UNREACHABLE macro which does nothing in release mode but throws an exception (or asserts with the line number) in debug mode.
| case RelationType::kJoin: | ||
| if (relationData->newPipelines.size() == kBinaryRelationInputCount) { | ||
| auto leftRelationData = ANY_CAST( | ||
| std::shared_ptr<RelationData>, relationData->newPipelines[0]->blob); |
There was a problem hiding this comment.
So this means...
read1 -> project1 -> join1
read2 -> project2 -> join1
In this case project1 will be the left and project2 will be the right?
