feat: extension spaces, functions, aggregation relations to binary #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EpsilonPrime
commented
Jun 7, 2023
•
EpsilonPrime
commented
- Features
- Extension spaces and functions are now emitted to the binary plan
- Details such as invocation, measures, groupings now implemented for aggregation relations and sorts for sort relations
- Fixes
- Type conversion to text standardized for schemas and extensions
- Changes lookupSymbolByLocation to return a pointer as the named lookup.
* Fields are now emitted in expressions completing expression handling.
* Schemas and sources are also now implemented.
…til all of the features have caught up.
EpsilonPrime
force-pushed
the
parser-part6
branch
from
5b89eb1
to
b5c4de5
Compare
EpsilonPrime
changed the title
EpsilonPrime
changed the title
westonpace
requested changes
Jun 8, 2023
| @@ -2,10 +2,13 @@ | |||
|
|
|||
| #include "substrait/textplan/converter/PlanPrinterVisitor.h" | |||
|
|
|||
| #include <iostream> | |||
There was a problem hiding this comment.
There are some stringstream operations going on so it's currently marked as being included. Eventually we should run an IWYU on the project (which we need to set up -- I added issue #70 for that).
| @@ -79,8 +86,16 @@ ParseResult parseStream(antlr4::ANTLRInputStream stream) { | |||
| *pipelineVisitor->getSymbolTable(), pipelineVisitor->getErrorListener()); | |||
| try { | |||
| relationVisitor->visitPlan(tree); | |||
| } catch (std::invalid_argument ex) { | |||
There was a problem hiding this comment.
Maybe add a comment what you are trying to catch here? Do you want to just grab any std::exception?
There was a problem hiding this comment.
Added a comment. When using std::exception it didn't catch the any_cast exception I was looking for.
westonpace
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.