feat: add binary plan normalizer #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normalizer orders the extension uri spaces and function extensions alphabetically (and renumbers accordingly) so that it is easier to compare binary plans. A slight change to the existing sort behavior is made to be consistent with this ordering.
westonpace
approved these changes
Jun 21, 2023
| @@ -254,7 +254,15 @@ std::string outputFunctionsSection(const SymbolTable& symbolTable) { | |||
| std::stringstream text; | |||
|
|
|||
| std::map<uint32_t, std::string> spaceNames; | |||
| std::set<uint32_t> usedSpaces; | |||
| auto cmp = [&](uint32_t a, uint32_t b) { | |||
There was a problem hiding this comment.
Maybe add a small comment just explaining why we are doing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normalizer orders the extension uri spaces and function extensions alphabetically (and renumbers accordingly) so that it is easier to compare binary plans. A slight change to the existing sort behavior is made to be consistent with this ordering.