Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add output field mapping #78

Merged
merged 10 commits into from
Jul 19, 2023
Merged

feat: add output field mapping #78

merged 10 commits into from
Jul 19, 2023

Conversation

EpsilonPrime
Copy link
Member

@EpsilonPrime EpsilonPrime commented Jul 5, 2023 •
edited
Loading

features:

  • updated the symbol table so that multiple symbols can share the same location
  • the root relation now contains both a relation symbol and a name structure symbol
  • moved commonly string search functions into a separate file
  • added EMIT
  • added aliases
  • added join types

fixes:

  • fixed root names sort order

@EpsilonPrime
feat: add asggregate output field mapping support
8fc2689 
features:
  * updated the symbol table so that multiple symbols can share the same location
  * the root relation now contains both a relation symbol and a name structure symbol
  * moved commonly string search functions into a separate file
  * added EMIT
  * added aliases
  * added join types
fixes:
  * fixed root names sort order
@EpsilonPrime
Ran clang tidy.
6e1c1da
@EpsilonPrime
Cleanup a symbol table access.
104e7f9
@EpsilonPrime
Updated tests based on recent changes.
233bb59
@EpsilonPrime
Make it easier for type deduction to happen with size_t type.
460645e
@EpsilonPrime
Fixed map insert on Linux.
11c107d
@EpsilonPrime
Added missing includes.
d6b41e2
@EpsilonPrime
Fixed narrowing issue.
48e2cf4
@EpsilonPrime
Finished fixing the tests.
7334e2d
westonpace
westonpace requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, still working through this.

src/substrait/textplan/StructuredSymbolData.h Outdated Show resolved Hide resolved
src/substrait/textplan/StructuredSymbolData.h Outdated Show resolved Hide resolved
src/substrait/textplan/converter/InitialPlanProtoVisitor.cpp Outdated Show resolved Hide resolved
src/substrait/textplan/converter/InitialPlanProtoVisitor.cpp Outdated Show resolved Hide resolved
src/substrait/textplan/converter/InitialPlanProtoVisitor.cpp Outdated Show resolved Hide resolved
src/substrait/textplan/converter/InitialPlanProtoVisitor.cpp Show resolved Hide resolved
westonpace
westonpace requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes. We might want to start collecting these TODO items somewhere other than the code. Otherwise, I think we can probably move forward with this.

src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp Outdated Show resolved Hide resolved
src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp Show resolved Hide resolved
src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp Outdated Show resolved Hide resolved
src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp Outdated Show resolved Hide resolved
src/substrait/textplan/parser/SubstraitPlanVisitor.cpp Outdated Show resolved Hide resolved
westonpace
westonpace approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the feedback!

@westonpace westonpace merged commit 0a71a2f into substrait-io:main Jul 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EpsilonPrime @westonpace