fix: support both old and new versions of protobuf #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version numbering scheme for the protobuf compiler was updated which causes a mismatch warning to appear for versions of cmake less than 3.27. Later versions of protobuf are bundled with their own copy of abseil. Since protobuf always required abseil anyway, this fix also updates the code to rely on that instead of our own submodule. This should lead to greater consistency (especially with new protobuf code leaning on an experimental logging feature that won't be available in older versions of abseil). If the newer CONFIG-based method of findpackage does not work, we now fall back to the older method of using findpackage. The version of cmake that we require is still 3.20 as 3.27 isn't available in enough locations to advance to that minimum.
westonpace
requested changes
Jul 10, 2023
…y determine if abseil is needed.
westonpace
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version numbering scheme for the protobuf compiler was updated which causes a mismatch warning to appear for versions of cmake less than 3.27. Later versions of protobuf are bundled with their own copy of abseil. Since protobuf always required abseil anyway, this fix also updates the code to rely on that (when available) instead of our own submodule. This should lead to greater consistency (especially with new protobuf code leaning on an experimental logging feature that won't be available in older versions of abseil). If the newer CONFIG-based method of findpackage does not work, we now fall back to the older method of using findpackage. The version of cmake that we require is still 3.20 as 3.27 isn't available in enough locations to advance to that minimum.