Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update antlr4 to version 4.13.0. #85

Merged
merged 3 commits into from
Aug 24, 2023
Merged

chore: Update antlr4 to version 4.13.0. #85

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd52cbe
chore: Update antlr4 to version 4.13.0.
EpsilonPrime Aug 22, 2023
1906270
Now uses the ANTLR4_TAG in the filename references.
EpsilonPrime Aug 23, 2023
3745cfb
Do not use the tag in the jar name which uses dashes instead of periods.
EpsilonPrime Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/substrait/textplan/parser/grammar/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ set(GRAMMAR_DIR ${CMAKE_BINARY_DIR}/src/substrait/textplan/parser/grammar)
# using /MD flag for antlr4_runtime (for Visual C++ compilers only)
set(ANTLR4_WITH_STATIC_CRT OFF)

set(ANTLR4_TAG 4.12.0)
set(ANTLR4_TAG 4.13.0)
set(ANTLR4_ZIP_REPOSITORY
https://github.com/antlr/antlr4/archive/refs/tags/4.12.0.zip)
https://github.com/antlr/antlr4/archive/refs/tags/${ANTLR4_TAG}.zip)

include(ExternalAntlr4Cpp)

include_directories(${ANTLR4_INCLUDE_DIRS})

file(DOWNLOAD https://www.antlr.org/download/antlr-4.12.0-complete.jar
file(DOWNLOAD https://www.antlr.org/download/antlr-4.13.0-complete.jar
EpsilonPrime marked this conversation as resolved.
Show resolved Hide resolved
"${GRAMMAR_DIR}/antlr.jar")
set(ANTLR_EXECUTABLE "${GRAMMAR_DIR}/antlr.jar")
find_package(ANTLR REQUIRED)
Expand Down