Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for all subquery types #89

Merged
merged 17 commits into from
Feb 7, 2024
Merged

feat: add support for all subquery types #89

merged 17 commits into from
Feb 7, 2024

Conversation

EpsilonPrime
Copy link
Member

No description provided.

@EpsilonPrime EpsilonPrime mentioned this pull request Feb 6, 2024
Merged
westonpace
westonpace approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add support for ANY in a follow-up and then I think we are good. Thanks for working through the difficult cases here.

Some minor questions/comments for cleanup if you're interested.

src/substrait/textplan/parser/grammar/SubstraitPlanParser.g4 Show resolved Hide resolved
src/substrait/textplan/parser/grammar/SubstraitPlanParser.g4 Outdated Show resolved Hide resolved
src/substrait/textplan/parser/grammar/SubstraitPlanLexer.g4 Show resolved Hide resolved
src/substrait/textplan/parser/SubstraitPlanVisitor.cpp Outdated Show resolved Hide resolved
src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.h Show resolved Hide resolved
src/substrait/textplan/parser/README.md Outdated Show resolved Hide resolved
src/substrait/textplan/converter/PlanPrinterVisitor.cpp Show resolved Hide resolved
src/substrait/textplan/SymbolTablePrinter.cpp Show resolved Hide resolved
src/substrait/textplan/SymbolTable.h Outdated Show resolved Hide resolved
@EpsilonPrime EpsilonPrime merged commit 4f6ed2f into substrait-io:main Feb 7, 2024
3 checks passed
@EpsilonPrime EpsilonPrime deleted the subqueries branch February 7, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EpsilonPrime @westonpace