Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interface files with mypy information to aid with type checking #52

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

EpsilonPrime
Copy link
Member

No description provided.

Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a reasonable change. I think you also need to add an empty file called py.typed in the src/ directory to inform downstream projects that type information is available.

@EpsilonPrime
Copy link
Member Author

this seems like a reasonable change. I think you also need to add an empty file called py.typed in the src/ directory to inform downstream projects that type information is available.

Having the type information and enforcing it seem like two different levels. I do want to add py.typed but I believe that should be done in a followup PR especially as it has the possibility to affect downstream packages.

@EpsilonPrime EpsilonPrime merged commit cbac90e into substrait-io:main Apr 1, 2024
13 checks passed
@EpsilonPrime EpsilonPrime deleted the mypy branch April 1, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants