Skip to content

Commit

Permalink
Fixed typos in: Update kalos.md
Browse files Browse the repository at this point in the history
Hello,

Here are two typos and correction recommendations:

1- "is allows memory write"

The phrase should be "allows memory write". The word "is" seems unnecessary.

2- "double initializtion/finalization"

"initializtion" is a typo; it should be "initialization".

Thanks.
  • Loading branch information
leonarddt05 authored Dec 27, 2024
1 parent bfb0c6d commit 2b068cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions audits/kalos.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ zkvm

# Findings

## 1. [Critical] `poseidon2/external` is allows memory write at arbitrary location, and hash value is also underconstrained
## 1. [Critical] `poseidon2/external` allows memory write at arbitrary location, and hash value is also underconstrained

`Poseidon2Chip` evaluates the Poseidon2 hash in-circuit, with SBOX $x^7$, 8 external rounds and 13 internal rounds. There are several underconstrains in the codebase which lead to a break of soundness of the hash function evaluation and the memory state in general.

Expand Down Expand Up @@ -244,7 +244,7 @@ This allows us to read incorrect previous values - at clock 2, the intuitive pre

The addresses of each row should be enforced to be different - this can be done by constraining that the address increases over the rows via bitwise decomposition. Note that adding this check in the initialize stage only is sufficient to resolve this issue.

Also, the verifier needs to enforce that only one table of `MemoryGlobalChip` exists, so that double initializtion/finalization cannot happen using multiple tables.
Also, the verifier needs to enforce that only one table of `MemoryGlobalChip` exists, so that double initialization/finalization cannot happen using multiple tables.

As similar vulnerability was found in the Core VM, and similar defenses can be applied here.

Expand Down

0 comments on commit 2b068cb

Please sign in to comment.