Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement format for sort #187

Merged

Conversation

florian-lackner365
Copy link
Contributor

Hello!

Thank you for this repo. It's really nice to work with the lib. I was missing the format option on Sort, so I implemented it.

If there's anything to change feel free to ping me and I'll fix it asap :)

have a good day!

@sudo-suhas
Copy link
Owner

Thanks for opening the PR @florian-lackner365. Do you have any idea in which version of Elasticsearch, the support for sort format was added? It would be good to call out the same in the documentation.

@florian-lackner365
Copy link
Contributor Author

it seems to have been released in 7.13. Yeah sure, what do you think about a little comment like:

The format argument is supported since version 7.13 of ElasticSearch.

source: https://stackoverflow.com/a/68861638

@sudo-suhas
Copy link
Owner

Ya, that sounds good

@florian-lackner365
Copy link
Contributor Author

there you go!

@sudo-suhas sudo-suhas merged commit ce60314 into sudo-suhas:master Oct 26, 2023
9 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@florian-lackner365
Copy link
Contributor Author

ty for the rapid release! it was a very nice experience contributing to your project 🎉 I'll come back if there's more to implement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants