Deprecate monitor.sh #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o logs instead of memcache
|
Wow! I am extremely excited to look at this. Thanks @haydenhw ! |
bennlich
reviewed
Dec 15, 2019
src/app.js
Outdated
| // If an exitnode has not checked in in the last two minutes, report an error message | ||
| const getExitnodeStats = function (exitnodeIP) { | ||
| return db.collection('routeLog') | ||
| .aggregate([ |
There was a problem hiding this comment.
Is an aggregation necessary here? I'm wondering if it would be simpler to fetch the most recent entry in the log for an exitnodeIP, and then count the number of nodes/gateways outside of mongo-land.
src/app.js
Outdated
| @@ -56,11 +56,44 @@ function MonitorApp ({ | |||
| } | |||
|
|
|||
| async function getMonitorUpdates() { | |||
There was a problem hiding this comment.
Might as well make this function name more specific while we're here. Could be something like your inner helper function -- latestExitnodeStats(). Or numNodesLastSeenAtExitnodes().
There was a problem hiding this comment.
I ended up renaming this to countActiveRoutesByExitnode(). Let me know if you like one of these other names better. Happy to change it to whatever
| mjs.set(key, JSON.stringify(processed), {expires: 120}, handleErr); | ||
| } | ||
| }); | ||
|
|
| }) | ||
| }) | ||
| } | ||
|
|
| }); | ||
| }); | ||
|
|
||
| }); |
…name getMonitorUpdates -> countActiveRoutesByExitnodes refactor getMonitorUpdates; rename to countActiveRoutesByExitnodes
|
Rad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #42