Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symfony form to render the comment form #26

Merged

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Aug 1, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR removes the html-form and replaces it with symfony form.

Why?

This form will be used to "deserialize" the request and therefore replaces the serializer for this.

Related: #27

@wachterjohannes wachterjohannes force-pushed the feature/symfony-form branch 6 times, most recently from 9852e7e to 81c5cc2 Compare August 1, 2019 15:02
@wachterjohannes wachterjohannes force-pushed the feature/symfony-form branch 2 times, most recently from 11ec5a0 to e434cf4 Compare August 1, 2019 15:11
@alexander-schranz alexander-schranz merged commit fafff3d into sulu:develop Aug 1, 2019
@wachterjohannes wachterjohannes deleted the feature/symfony-form branch August 2, 2019 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants