Skip to content

Commit

Permalink
d/w expanse setup, moved {env} {res} {custom} (#834)
Browse files Browse the repository at this point in the history
feedback for expanse scripts, moved {env} {res} {custom}, removed the source ./bashrc since that can be handled in {custom}

also note-- new test for 3.7 failing d/t external error "functools" import
  • Loading branch information
jchen6727 authored Sep 17, 2024
1 parent a5b7a12 commit 709eaf1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions netpyne/batchtools/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ def run(config):
('sh', 'sfs' ): constructors(runtk.dispatchers.SFSDispatcher , submits.SHSubmitSFS),
}#TODO, just say "socket"?


"""
some shim functions before ray_search
"""
Expand Down
10 changes: 5 additions & 5 deletions netpyne/batchtools/submits.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,8 @@ class SlurmSubmit(Submit):
#SBATCH --mail-user={email}
#SBATCH --mail-type=end
export JOBID=$SLURM_JOB_ID
{res}
{env}
{custom}
source ~/.bashrc
cd {project_path}
{command}
wait
Expand Down Expand Up @@ -227,8 +226,8 @@ class SlurmSubmitSFS(SlurmSubmit):
export JOBID=$SLURM_JOB_ID
export OUTFILE="{output_path}/{label}.out"
export SGLFILE="{output_path}/{label}.sgl"
{env}
{custom}
source ~/.bashrc
cd {project_path}
{command}
wait
Expand All @@ -254,13 +253,14 @@ class SlurmSubmitSOCK(SlurmSubmit):
#SBATCH --mail-type=end
export JOBID=$SLURM_JOB_ID
export SOCNAME="{sockname}"
{env}
{custom}
source ~/.bashrc
cd {project_path}
{command}
wait
"""
script_handles = {runtk.SUBMIT: '{output_path}/{label}.sh',
runtk.STDOUT: '{output_path}/{label}.run',
runtk.SOCKET: '{sockname}'
}
}

0 comments on commit 709eaf1

Please sign in to comment.